Skip to content

Removing unused legacy price code #14218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jonathanKingston
Copy link
Contributor

Description

Removing some legacy code that doesn't ever look used in m2. There don't appear to be ant elements with #price_default in the code. This is one of the many uses of Event.observe which hopefully we can move towards removing.

The code doesn't appear to have tests or any other remaining structure relating to it.

Manual testing scenarios

  1. Check anything that would contain prices, however as mentioned I can't see anything that would trigger this code.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@rogyar rogyar self-assigned this Mar 21, 2018
@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 21, 2018
@magento-engcom-team magento-engcom-team merged commit ecd9dfa into magento:2.3-develop Mar 23, 2018
@jonathanKingston jonathanKingston deleted the 2.3-develop_remove-unused-price branch March 24, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants